Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tutorial step three #154

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Improve tutorial step three #154

merged 2 commits into from
Oct 16, 2017

Conversation

fernahh
Copy link
Contributor

@fernahh fernahh commented Oct 13, 2017

There is a issue about a guy that has excluded the src/ folder. To avoid future issues, I have improved step three with:

  • inside instead of in
  • added a parentheses with don't exclude the folder, just the files

resolves #71

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot
Copy link

reactjs-bot commented Oct 13, 2017

Deploy preview ready!

Built with commit 471fec4

https://deploy-preview-154--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -54,7 +54,7 @@ If you want to do it, here are the steps to follow:

1. Make sure you have a recent version of [Node.js](https://nodejs.org/en/) installed.
2. Follow the [installation instructions](/docs/installation.html#creating-a-new-application) to create a new project.
3. Delete all files in the `src/` folder of the new project.
3. Delete all files inside the `src/` folder of the new project (don't exclude the folder, just the files).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(don't exclude the folder, just the files).

I'm not sure the wording for this is clear. How do you feel about:

don't delete the folder, just its contents (eg rm -f src/*)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I'm update this.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bvaughn bvaughn merged commit bc9aa39 into reactjs:master Oct 16, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
* Add Universal Style Guide tranalation

* [WIP] Translate Glossary (reactjs#109)

* Translate Glossary

* Add Universal Style Guide to glossary as suggested

* Add Universal Style Guide tranalation

* Little fix

* Fix merge issues
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
docs(cn): translate content/docs/refs-and-the-dom.md into Chinese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clarity to Tutorial step 3
4 participants